Restore DigitalRoot legacy API compatibility - #104
Closed
krotname wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
Закрываю как superseded by #116: изменения перенесены в одну проверенную ветку, все review findings учтены; локальный mvn verify прошёл полностью. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
digital_root(int)todigitalRoot(int)so existing callers and Codewars harnesses continue to work.Description
public static int digital_root(int n)that delegates to the existingdigitalRoot(int)implementation to preserve a single centralized behavior.@Deprecatedto encourage migration while retaining the old API.shouldReduceNumberToSingleDigitto assert the legacy method returns the same results asdigitalRoot(int)anddigitalRootRecursiveStream(int)for the existing test cases.Testing
mvn -B -DskipTests=false test, and all tests passed (597 tests, 0 failures/errors).mvn -B verify, and the build succeeded with coverage thresholds met and no Checkstyle/PMD/SpotBugs issues.Codex Task